This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ser-unix.c: Add hardware flow control support
- From: Daniel Jacobowitz <drow at false dot org>
- To: "Maciej W. Rozycki" <macro at mips dot com>, Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, Chris Dearman <chris at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Mon, 21 May 2007 08:50:13 -0400
- Subject: Re: ser-unix.c: Add hardware flow control support
- References: <Pine.LNX.4.61.0703301233210.3670@perivale.mips.com> <20070330120821.GA7415@caradoc.them.org> <Pine.LNX.4.61.0705021502290.28428@perivale.mips.com> <Pine.LNX.4.61.0705211303420.27238@perivale.mips.com>
On Mon, May 21, 2007 at 01:21:51PM +0100, Maciej W. Rozycki wrote:
> On Wed, 2 May 2007, Maciej W. Rozycki wrote:
>
> > > I noticed while looking for the right place to put the option that we
> > > have an empty "set serial". Perhaps it should go under that instead.
> > > No strong preference.
> >
> > Well, we have "set remotebaud", which is at the top-level as well. And
> > which actually raises a question as to whether "set remoteflow" should not
> > be handled through "struct serial_ops" too? This way other serial
> > interfaces would have a chance to handle the option as well if somebody
> > cared.
> >
> > Any opinions?
>
> OK, I gather there is no potential interest in platform-independent
> approach at the moment, so I guess it may be implemented based on
> ser-unix.c if a need arises. Here is my current version of the patch.
This is fine with me; Eli, are the documentation changes OK?
--
Daniel Jacobowitz
CodeSourcery