Re: [rfc/rft] Eliminate gdbarch_read_sp callback function

["Ulrich Weigand" <uweigand at de dot ibm dot com>]

Daniel Jacobowitz wrote:
> On Sun, May 13, 2007 at 02:29:41PM +0200, Ulrich Weigand wrote:
> > Hello,
> > 
> > this patch moves the last remaining implementations of the gdbarch_read_sp
> > callback over to gdbarch_unwind_sp, and removes the callback.
> > 
> > The avr-tdep.c and score-tdep.c conversions are straightfoward; but I'm
> > not completely sure about the mips-tdep.c.  The old read_sp implementation
> > used to read the real MIPS_SP_REGNUM, but the unwind_pc implementation
> > unwinds the pseudo NUM_REGS + mips_regnum (gdbarch)->pc.
> > 
> > The patch implements unwind_sp using the pseudo NUM_REGS + MIPS_SP_REGNUM
> > as well.  Dan, you've been working on mips lately -- do you think this
> > is the correct choice?  Any chance you could run a test?  Thanks!
> 
> This conversion looks fine to me, and Joel tested Irix - I'd say you
> can go ahead.  I hope I'll be back to working on MIPS this week,
> though I have to sort out the shared library work first.

OK, I've committed this now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com