This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] testsuite/gdb.mi useless commands
- From: Denis PILAT <denis dot pilat at st dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 14 May 2007 10:16:20 +0200
- Subject: [commit] testsuite/gdb.mi useless commands
- References: <46237F14.1000904@st.com> <20070511174817.GF22529@caradoc.them.org>
Daniel Jacobowitz wrote:
On Mon, Apr 16, 2007 at 03:50:12PM +0200, Denis PILAT wrote:
This patch removes the commands mi_gdb_reinitialize_dir, mi_gdb_load and
mi_delete_breakpoints that has been moved into the *proc mi_run_to_main* of
lib/mi-support.exp.
It quicks up the testsuite execution time, not a lot for native targets,
but this has a real impact when your targets take a while to load binary files.
No regression in the testsuite for i686-pc-linux-gnu gdb.
Ok for commit?
This is OK, thanks.
Just commit the attached one !
--
Denis
2007-05-14 Denis Pilat <denis.pilat@st.com>
* gdb.mi/mi-console.exp, gdb.mi/gdb669.exp, gdb.mi/mi-cli.exp,
gdb.mi/mi-regs.exp, gdb.mi/mi-stepi.exp, gdb.mi/mi-syn-frame.exp,
gdb.mi/mi2-cli.exp, gdb.mi/mi2-console.exp, gdb.mi/mi2-disassemble.exp,
gdb.mi/mi2-regs.exp, gdb.mi/mi2-stepi.exp, gdb.mi/mi-disassemble.exp,
gdb.mi/mi2-syn-frame.exp: Remove commands already run in mi_run_to_main.
Index: gdb.mi/gdb669.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb669.exp,v
retrieving revision 1.6
diff -u -p -r1.6 gdb669.exp
--- gdb.mi/gdb669.exp 9 Jan 2007 17:59:13 -0000 1.6
+++ gdb.mi/gdb669.exp 14 May 2007 08:03:44 -0000
@@ -183,9 +183,6 @@ if {[gdb_compile_pthreads "$srcdir/$subd
return -1
}
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load $binfile
-
mi_run_to_main
check_mi_and_console_threads "at main"
Index: gdb.mi/mi-cli.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-cli.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi-cli.exp
--- gdb.mi/mi-cli.exp 9 Jan 2007 17:59:13 -0000 1.7
+++ gdb.mi/mi-cli.exp 14 May 2007 08:03:44 -0000
@@ -36,8 +36,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_gdb_reinitialize_dir $srcdir/$subdir
-
mi_gdb_test "-interpreter-exec" \
{\^error,msg="mi_cmd_interpreter_exec: Usage: -interpreter-exec interp command"} \
"-interpreter-exec with no arguments"
Index: gdb.mi/mi-console.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-console.exp,v
retrieving revision 1.18
diff -u -p -r1.18 mi-console.exp
--- gdb.mi/mi-console.exp 9 Jan 2007 17:59:13 -0000 1.18
+++ gdb.mi/mi-console.exp 14 May 2007 08:03:44 -0000
@@ -49,10 +49,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
mi_run_to_main
# Next over the hello() call which will produce lots of output
Index: gdb.mi/mi-disassemble.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-disassemble.exp,v
retrieving revision 1.16
diff -u -p -r1.16 mi-disassemble.exp
--- gdb.mi/mi-disassemble.exp 9 Jan 2007 17:59:13 -0000 1.16
+++ gdb.mi/mi-disassemble.exp 14 May 2007 08:03:44 -0000
@@ -38,10 +38,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc test_disassembly_only {} {
global mi_gdb_prompt
global hex
Index: gdb.mi/mi-regs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-regs.exp,v
retrieving revision 1.15
diff -u -p -r1.15 mi-regs.exp
--- gdb.mi/mi-regs.exp 9 Jan 2007 17:59:13 -0000 1.15
+++ gdb.mi/mi-regs.exp 14 May 2007 08:03:44 -0000
@@ -42,10 +42,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc sparc_register_tests_no_exec { } {
# Test the generic IDT chip.
mi_gdb_test "111-data-list-register-values" \
Index: gdb.mi/mi-stepi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-stepi.exp,v
retrieving revision 1.13
diff -u -p -r1.13 mi-stepi.exp
--- gdb.mi/mi-stepi.exp 9 Jan 2007 17:59:13 -0000 1.13
+++ gdb.mi/mi-stepi.exp 14 May 2007 08:03:56 -0000
@@ -40,11 +40,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc test_stepi_nexti {} {
global mi_gdb_prompt
global hex fullname_syntax srcfile
Index: gdb.mi/mi-syn-frame.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-syn-frame.exp,v
retrieving revision 1.10
diff -u -p -r1.10 mi-syn-frame.exp
--- gdb.mi/mi-syn-frame.exp 29 Apr 2007 16:20:50 -0000 1.10
+++ gdb.mi/mi-syn-frame.exp 14 May 2007 08:03:56 -0000
@@ -38,9 +38,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
mi_gdb_exit
mi_gdb_start
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
mi_run_to_main
mi_gdb_test "400-break-insert foo" \
Index: gdb.mi/mi2-cli.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-cli.exp,v
retrieving revision 1.6
diff -u -p -r1.6 mi2-cli.exp
--- gdb.mi/mi2-cli.exp 9 Jan 2007 17:59:13 -0000 1.6
+++ gdb.mi/mi2-cli.exp 14 May 2007 08:03:56 -0000
@@ -36,8 +36,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_gdb_reinitialize_dir $srcdir/$subdir
-
mi_gdb_test "-interpreter-exec" \
{\^error,msg="mi_cmd_interpreter_exec: Usage: -interpreter-exec interp command"} \
"-interpreter-exec with no arguments"
Index: gdb.mi/mi2-console.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-console.exp,v
retrieving revision 1.6
diff -u -p -r1.6 mi2-console.exp
--- gdb.mi/mi2-console.exp 9 Jan 2007 17:59:13 -0000 1.6
+++ gdb.mi/mi2-console.exp 14 May 2007 08:03:56 -0000
@@ -49,10 +49,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
mi_run_to_main
# Next over the hello() call which will produce lots of output
Index: gdb.mi/mi2-disassemble.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-disassemble.exp,v
retrieving revision 1.6
diff -u -p -r1.6 mi2-disassemble.exp
--- gdb.mi/mi2-disassemble.exp 9 Jan 2007 17:59:13 -0000 1.6
+++ gdb.mi/mi2-disassemble.exp 14 May 2007 08:03:56 -0000
@@ -38,10 +38,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc test_disassembly_only {} {
global mi_gdb_prompt
global hex
Index: gdb.mi/mi2-regs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-regs.exp,v
retrieving revision 1.5
diff -u -p -r1.5 mi2-regs.exp
--- gdb.mi/mi2-regs.exp 9 Jan 2007 17:59:13 -0000 1.5
+++ gdb.mi/mi2-regs.exp 14 May 2007 08:04:02 -0000
@@ -42,10 +42,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc sparc_register_tests_no_exec { } {
# Test the generic IDT chip.
mi_gdb_test "111-data-list-register-values" \
Index: gdb.mi/mi2-stepi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-stepi.exp,v
retrieving revision 1.6
diff -u -p -r1.6 mi2-stepi.exp
--- gdb.mi/mi2-stepi.exp 9 Jan 2007 17:59:13 -0000 1.6
+++ gdb.mi/mi2-stepi.exp 14 May 2007 08:04:02 -0000
@@ -40,11 +40,6 @@ if { [gdb_compile "${srcdir}/${subdir}/
return -1
}
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
-
proc test_stepi_nexti {} {
global mi_gdb_prompt
global hex fullname_syntax srcfile
Index: gdb.mi/mi2-syn-frame.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-syn-frame.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi2-syn-frame.exp
--- gdb.mi/mi2-syn-frame.exp 29 Apr 2007 16:20:50 -0000 1.7
+++ gdb.mi/mi2-syn-frame.exp 14 May 2007 08:04:02 -0000
@@ -40,9 +40,6 @@ set my_mi_gdb_prompt "\\(gdb\\)\[ \]*\[\
mi_gdb_exit
mi_gdb_start
-mi_delete_breakpoints
-mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
mi_run_to_main
mi_gdb_test "400-break-insert foo" \