This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Eliminate write_register from solib-sunos.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 13 May 2007 19:55:30 -0400
- Subject: Re: [rfc] Eliminate write_register from solib-sunos.c
- References: <200705120031.l4C0VDqg010367@d12av02.megacenter.de.ibm.com>
On Sat, May 12, 2007 at 02:31:13AM +0200, Ulrich Weigand wrote:
> Hello,
>
> solib-sunos.c has a place where it adjusts the PC by DECR_PC_AFTER_BREAK.
> Unlike all other places to do so, it uses write_register (PC_REGNUM ...).
>
> As I'm trying to eliminate write_register, I'd like to get rid of this.
> The following patch replaces the write_register call by write_pc.
>
> Is this OK?
I noticed this call last week. I'm not sure if any platform using
solib-sunos.c even triggers it... but if they do, I think it's
decrementing the PC twice. Didn't infrun take care of it?
--
Daniel Jacobowitz
CodeSourcery