This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: mark dot kettenis at xs4all dot nl (Mark Kettenis)
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 2 May 2007 01:12:29 +0200 (CEST)
- Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
Mark Kettenis wrote:
> 1. core_fns/core_read_registers should really die (it'd already
> deprecated) and replaced by gdbarch_regset_from_core_section().
>
> 2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset
> should really be replaced by something like
> gdbarch_regset_from_core_section().
I agree, but those changes are difficult to make without having
the target to test on. In particular making sure the osabi sniffer
detects the core file correctly is something that really needs
to be tested ... That's why I left those things as-is for now.
> That said, this diff is great progress, and I think it should go in
> ASAP. It's probably polite to give other responsable maintainers the
> opportunity to react to the diff. So consider this an explicit ok for
> the i387 targets.
Thanks! I'll wait for a couple of days for further comments before
checking it in (but not too long -- I really don't want mainline to
change so much I'll have to re-do the patch set ...).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com