This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa] Eliminate supply_gregset etc. from -tdep files
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 29 Apr 2007 12:46:13 -0400
- Subject: Re: [rfa] Eliminate supply_gregset etc. from -tdep files
- References: <200704291618.l3TGIOoh025532@d12av02.megacenter.de.ibm.com>
On Sun, Apr 29, 2007 at 06:18:24PM +0200, Ulrich Weigand wrote:
> Hello,
>
> there are two -tdep files (m68k-tdep.c and mips-linux-tdep.c) that contain
> implementations of the supply_greget family of functions. This is incorrect;
> those function should only ever be provided by native support files.
"Incorrect" may be a bit strong. core-regset.c needs them to link; at
one point, that was the right way to implement core file support. I
don't remember how the history worked out for mips, since it doesn't
look like the version in the FSF repository ever used core-regset.o,
but I think that was the original motivation.
Anyway, now there are no targets that use core-regset.o in .mt files,
and no good reason to do so. So now it's incorrect :-) This patch is
OK.
--
Daniel Jacobowitz
CodeSourcery