Re: [RFC] DW_AT_type missing from DW_TAG_subrange_type

[Denis PILAT <denis dot pilat at st dot com>]

Daniel Jacobowitz wrote:
> On Wed, Apr 18, 2007 at 02:51:31PM +0200, Denis PILAT wrote:
>   
> > 2007-04-18  Denis Pilat  <denis.pilat@st.com>
> >
> > 	* dwarf2read.c (read_subrange_type): Use of DW_ATE_signed default type
> > 	when missing from DW_TAG_subrange_type. Remove the handling of null
> > 	return from die_type().
> >     
>
> This is OK with two small changes.  First, the changelog entry should be:
>
> 	* dwarf2read.c (read_subrange_type): Use DW_ATE_signed default type
> 	when missing from DW_TAG_subrange_type.  Remove the handling of null
> 	return from die_type.
>
> (Grammar fix, two spaces between sentences, no parentheses after the
> name of a function - that's a recent change in the GNU standards, I
> think)
>
>   
> > +      base_type = dwarf_base_type (DW_ATE_signed, TARGET_ADDR_BIT /8, cu);
> >     
>
> And a space on each side of the "/".
>
> Thanks!
>
>   
Ok, that means I did a mistake in my previous ChangeLog entry about 
target_terminal_ours ?
Can I change it as well in the same commit, removing "()" ?

Denis