This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Patch for isdigit/isalpha/etc. macro arguments
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: mark dot kettenis at xs4all dot nl
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 6 Apr 2007 16:59:44 -0700 (PDT)
- Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
> Bleach! So that's not a viable option. I think it's time to find the
> magic gcc option to turn the warning off. I mean
>
> char *s = "...";
> isalpha(*s);
>
> is perfectly reasonable code and should not result in compiler
> warnings. And I really don't like adding the casts you propose. To
> me, a cast is an indication that something naughty is being done, and
> that certainly isn't the case here.
>
> Mark
That would be -Wno-char-subscripts. I'll look into adding it.
Steve Ellcey
sje@cup.hp.com