This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] re-initialize height to 0 during setshow.exp
- From: Michael Snyder <Michael dot Snyder at access-company dot com>
- To: Denis PILAT <denis dot pilat at st dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 02 Apr 2007 10:56:31 -0700
- Subject: Re: [RFA] re-initialize height to 0 during setshow.exp
- References: <461119CA.6060509@st.com>
On Mon, 2007-04-02 at 16:57 +0200, Denis PILAT wrote:
> In testsuite/gdb.base/setshow.exp, after "set height 100", it could
> occur that following commands require user interaction to proceed like:
> ---Type <return> to continue, or q <return> to quit---
> (At least it's the case for our gdb in "show user" since we have defined
> a lot of user command.)
>
> Attach is a patch that fixes a problem in this test.
> We could also add
> gdb_test "set height 0" "" "set height 0"
> or increase the height to a very large number, but I prefer to reset
> height to 0 like done in gdb.exp.
>
I think it's valid, but I wonder why you didn't just use gdb_test,
instead of gdb_expect? Are you expecting the command to fail or
time out or something?