This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems


> Hmmm, You are probably right. I copied this copyright blurb from
> another file without paying enough attention. I think the physmem.c
> copyright notice will be more appropriate, but I will double-check
> where the macro is being used.

The macro is only used in java/jcf-path.c and protoize.c, so I don't
think it needs the exclusion.

Here is a revised version of the patch that should address both
comments (copyright notice, and lack of documentation):

libiberty/ change:
2007-03-28  Joel Brobecker  <brobecker@adacore.com>

        * filename_cmp.c: New file.
        * Makefile.in (CFILES): Add filename_cmp.c.
        (REQUIRED_OFILES): Add filename_cmp.o
        (filename_cmp.o): New rule.
        * functions.texi: Regenerate.

include/ change:
2007-03-28  Joel Brobecker  <brobecker@adacore.com>

        * filenames.h (FILENAME_CMP): Adjust define to call filename_cmp
        regardless of the type of file system.

The documentation change was tested by regenerating function.texi
then regenerating the .info documentation, and finally by browsing
the resulting document with the "info" program.

OK to apply?

Thank you,
-- 
Joel

Attachment: filename_cmp.c
Description: Text document

Attachment: filename_cmp.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]