This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: mips-tdep.c: FP varargs fixes
- From: Andreas Schwab <schwab at suse dot de>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: gdb-patches at sourceware dot org, Nigel Stephens <nigel at mips dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Fri, 23 Mar 2007 15:53:19 +0100
- Subject: Re: mips-tdep.c: FP varargs fixes
- References: <Pine.LNX.4.61.0703231339070.6921@perivale.mips.com>
"Maciej W. Rozycki" <macro@mips.com> writes:
> @@ -3272,7 +3283,7 @@
> /* Write this portion of the argument to a general
> purpose register. */
> if (argreg <= MIPS_LAST_ARG_REGNUM
> - && !fp_register_arg_p (typecode, arg_type))
> + /*&& !fp_register_arg_p (typecode, arg_type)*/)
Please don't comment out code, remove it instead, and add a comment why it
was removed.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."