This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: mips-tdep.c: FP varargs fixes
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: macro at mips dot com
- Cc: gdb-patches at sourceware dot org, nigel at mips dot com, macro at linux-mips dot org
- Date: Fri, 23 Mar 2007 15:49:26 +0100 (CET)
- Subject: Re: mips-tdep.c: FP varargs fixes
- References: <Pine.LNX.4.61.0703231339070.6921@perivale.mips.com>
> Date: Fri, 23 Mar 2007 14:41:16 +0000 (GMT)
> From: "Maciej W. Rozycki" <macro@mips.com>
> @@ -3272,7 +3283,7 @@
> /* Write this portion of the argument to a general
> purpose register. */
> if (argreg <= MIPS_LAST_ARG_REGNUM
> - && !fp_register_arg_p (typecode, arg_type))
> + /*&& !fp_register_arg_p (typecode, arg_type)*/)
> {
> LONGEST regval = extract_signed_integer (val, partial_len);
> /* Value may need to be sign extended, because
>
What's up with this bit? Your ChangeLog message says this:
> boundary, align stack_offset too. Write floating-point
> arguments to the appropriate integer register, if we're not
> passing in a floating point register.
But that matches the old code, not the new code.
In any case please don't comment out code like that. The code is
either right or wring. In the latter case it should be removed. If
there is something non-obvious going on, it needs a proper comment.
Thanks,
Mark