This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch]: Little Cleanup
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <pedro_alves at portugalmail dot pt>
- Cc: deuling at de dot ibm dot com, gdb-patches at sourceware dot org
- Date: Sat, 03 Mar 2007 12:29:06 +0200
- Subject: Re: [Patch]: Little Cleanup
- References: <45E7CC17.5040304@de.ibm.com> <45E93AE5.5050704@portugalmail.pt>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sat, 03 Mar 2007 09:07:49 +0000
> From: Pedro Alves <pedro_alves@portugalmail.pt>
> CC: GDB Patches <gdb-patches@sourceware.org>
>
> Markus Deuling wrote:
> > @@ -2909,8 +2902,7 @@
> >
> > if (!breakpoints_inserted && !ecs->another_trap)
> > {
> > - breakpoints_failed = insert_breakpoints ();
> > - if (breakpoints_failed)
> > + if (insert_breakpoints ())
> > {
> > stop_stepping (ecs);
> > return;
> >
> >
>
> Actually, I find your version harder to read for someone not knowing the
> insert_breakpoints API by heart.
FWIW, I agree. The new version requires a comment to be as readable
as the old one.
(Of course, I'd expect the optimizer to produce the same code from
both old and new versions.)