This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "target remote | " stderr
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 17 Feb 2007 17:30:58 +0300
- Subject: Re: "target remote | " stderr
- References: <200701261653.53834.vladimir@codesourcery.com> <E1HIK6J-000273-D7@zigzag.lvk.cs.msu.su> <ubqjtkq7r.fsf@gnu.org>
On Saturday 17 February 2007 13:56, Eli Zaretskii wrote:
> > From: Vladimir Prus <ghost@cs.msu.su>
> > Date: Sat, 17 Feb 2007 10:34:36 +0300
> >
> > >> + int error_fd; /* File descriptor for a separate
> > >> + error stream that should be
> > >> + immediately forwarded to gdb_stderr.
> > >> + This may be -1.
> > >> + If != -1, this descriptor should
> > >> + be non-blocking. */
> > >
> > > This comment isn't according to GNU coding standards, I think.
> >
> > Can you please be more specific?
>
> Not sure what you want me to say.
Well...
> Multiline, multiple-sentence
> comments should not be alongside of the code, they should precede the
> code.
... the above. With your original comment I went looking for
missing double spaces, found none, and had no idea what you mean.
- Volodya