This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Formatting changes to mi-main.c
> Date: Sat, 03 Feb 2007 13:36:58 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Nick Roberts <nickrob@snap.net.nz>
> > Date: Sat, 3 Feb 2007 18:43:46 +1300
> >
> > 2007-02-03 Nick Roberts <nickrob@snap.net.nz>
> >
> > * mi/mi-main.c: Numerous formatting changes.
>
> Thanks for taking care of this.
>
> However:
>
> > *** 40,46 ****
> > #include "interps.h"
> > #include "event-loop.h"
> > #include "event-top.h"
> > ! #include "gdbcore.h" /* for write_memory() */
> > #include "value.h"
> > #include "regcache.h"
> > #include "gdb.h"
> > --- 40,46 ----
> > #include "interps.h"
> > #include "event-loop.h"
> > #include "event-top.h"
> > ! #include "gdbcore.h" /* For write_memory(). */
>
> Anyway, the above isn't a complete sentence anyway, even if we begin
> it with a capital letter and end it with a period.
The above comment is pointless anyway. And probably misleading,
because the file probably needs gdbcore.h for things besides
write_memory by now.
I encourage people deleting similar comments, and we really shouln't
add any new comments like that, until something very non-obvious is
going on. In that case you'd probably need several sentences anyway
to explain things.
Mark