This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [mi] kill release_value calls


On Wed, Jan 24, 2007 at 10:33:30PM +0300, Vladimir Prus wrote:
> 
> This patch removes all calls to release_value in varobj.c, except
> for one. We only need to call release_value when we're storing
> a value for indefinite future use, and install_new_value is the
> only such place.  The extra release_value calls either 
> are time-consuming no-ops, or lead to memory leaks, 
> depending on the value type.
> 
> OK?

OK.  My apologies to Nick - I'd told him this was wrong, but I was
mistaken.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]