This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] thread apply commands change selected frame
- From: Daniel Jacobowitz <drow at false dot org>
- To: Denis PILAT <denis dot pilat at st dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Sun, 21 Jan 2007 12:33:41 -0500
- Subject: Re: [RFC] thread apply commands change selected frame
- References: <45A61E73.8030400@st.com>
On Thu, Jan 11, 2007 at 12:24:35PM +0100, Denis PILAT wrote:
> Hi everyone,
>
> I noticed a potential problem in thread.c: the "thread apply" commands
> change the selected frame, I think it should not.
> If you are doing
> (gdb) up
> (gdb) thread apply all print 1
> (gdb) down
> then the frame selected before the up is not being restored by the down,
> we have an error message instead.
Yeah, that's a strange behavior.
> I need your opinion before going ahead in this patch.
It looks right to me. With a ChangeLog entry and testsuite results
from some target with threads, it would be OK to commit.
--
Daniel Jacobowitz
CodeSourcery