This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mi-basics.exp


On Thu, Jan 11, 2007 at 12:10:48PM +1300, Nick Roberts wrote:
> [2nd attempt, I'm not sure where the first post ended up]
> 
> This is to fix the annoying fails that occur in mi-basics.exp when srcdir is a
> relative pathname in site.exp.  It uses objdir instead of srcdir for the tests
> which always seems to be an absolute filename, although I don't know where
> runtest gets its value.
> 
> If approved, I'll make the same change for mi2-basics.exp.

OK, and thanks a lot for fixing this.  objdir is fine; it seems that
dejagnu always arranges to set that to a full path (unless you specify
it yourself in site.exp or on the command line, which we don't).

> --- 221,234 ----
>       }
>   
>       set orig_path [string_to_regexp ${orig_path}]
> +     set pathdir [string_to_regexp ${objdir}/${subdir}]
>   
>       mi_gdb_test "207-environment-path" \
>                "207\\\^done,path=\"$orig_path\"" \
>                "environment-path no-args operation"
>   
> !     mi_gdb_test "208-environment-path $objdir ${objdir}/${subdir}" \
> !              "208\\\^done,path=\"$escapedobjdir.${envirodir}.$orig_path\"" \
>                "environment-path dir1 dir2 operation"
>   
>       mi_gdb_test "209-environment-path -r $objdir" \

I think pathdir is unused.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]