This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MI: Add value field to output of -var-create


On Tue, Jan 02, 2007 at 11:07:34PM +1300, Nick Roberts wrote:
> 
> This patch just adds the value field to the output of var-create so that
> the frontend doesn't need to issue another command to find out what it
> is.
> 
> If approved, I'll change the tests and documentation accordingly.

Seems fine to me, after we work out what to do with the testsuite. I
went to check whether this should be PRINT_ALL_VALUES or
PRINT_SIMPLE_VALUES but it seems fine the way you've got it - I wish
I could remember the rational for PRINT_SIMPLE_VALUES properly.

One alternative that does not affect the testsuite would be to add
an --all-values option to -var-create.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]