This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align


> Date: Fri, 5 Jan 2007 18:37:28 +0400
> From: Joel Brobecker <brobecker@adacore.com>

> > Ah wait, that's true even for "absolute" code.  I had a quick look at
> > the GCC code and it seems to always treat %ebx as callee-saved.  So
> > I'm happy with leaving it out, but you could add a comment saying so
> > to prevent us from having this same discussion in about two months
> > ;-).
> 
> Sure! How does the attached patch look? Does it contain enough info?

More than enough.  Please commit after adding the missing space before
"GCC should never...".

> 2007-01-05  Joel Brobecker  <brobecker@adacore.com>
> 
>         * i386-tdep.c (i386_analyze_stack_align): Add comment.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]