This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: MI - Detecting change of string contents with variable objects
On Fri, Jan 05, 2007 at 05:46:32PM +1300, Nick Roberts wrote:
> > > I'm not sure if we'll do that any more after your patch, e.g. if something
> > > beyond the limit of "set print elements" changes. So, do you think any
> > > front end relies on the parent being marked updated if any of its children
> > > are? Vlad, any opinion?
> >
> > I think the code in question is never executed for structures or arrays --
> > only for "changeable" values.
>
> I agree. Below is my latest patch, incorporating some of your suggestions.
This looks fine to me if it's fine with Vlad.
> gdb_assert (!value_lazy (var->value));
> ! gdb_assert (!value_lazy (value));
> !
> ! if (!value_contents_equal (var->value, value))
> ! changed = 1;
Why are you removing the second assert here?
--
Daniel Jacobowitz
CodeSourcery