This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2

From: Joel Brobecker <brobecker at adacore dot com>
To: Mark Kettenis <kettenis at sibelius dot xs4all dot nl>
Cc: mark dot kettenis at xs4all dot nl, gdb-patches at sourceware dot org
Date: Tue, 26 Dec 2006 09:13:03 +0400
Subject: Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2
References: <20061224093615.GH19684@adacore.com> <200612241458.kBOEw8uf016599@brahms.sibelius.xs4all.nl>

> > 2006-12-24  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * sparc64-tdep.c (sparc64_extract_return_value): Add handling
> >         for array types.
> >         (sparc64_store_return_value): Likewise.
> > 
> > Tested on sparc64-sun-solaris2.8, no regression. OK to commit?

> With that change this is ok.

Thanks Mark, I made the change you asked, and committed the change.

> However, did you check how small arrays of floating-point numbers are
> returned?  I suspect there might be an issue with those.

I just double-checked, and it seems to be working just fine. 
What I will do is extend our array-return testcase to include
this type of array too.

Thank you,
-- 
Joel

Follow-Ups:
- Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2
  - From: Mark Kettenis

References:
- [RFA/sparc64] internal-error printing return value (Ada array) - take 2
  - From: Joel Brobecker
- Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]