This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Cleanup varobj children handling


On Friday 22 December 2006 01:37, Nick Roberts wrote:
>  > > This patch changes varobj.c to use VEC for hodling children, thereby
>  > > making three functions unnecessary. No regressions in MI tests. OK?
>  > 
>  > Here's a revised patch, that additionally replaces 'vstack' code in varobj.c
>  > with VEC(). All in all, some 130 lines of code gets wiped now. OK?
> 
> I'm not familiar with vec.c yet - perhaps you and Daniel J discussed this issue
> privately - all I can say is that varobj. c has the comment:
> 
> /* Every variable keeps a linked list of its children, described
>    by the following structure. */
> /* FIXME: Deprecated.  All should use vlist instead */
> 
> Buy perhaps this is not relevant.

The comment was written before vec.c was available, so it naturally
does not suggest vec.c.

- Volodya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]