Re: [PATCH] Fix variable objects for references to pointers

[Vladimir Prus <ghost at cs dot msu dot su>]

Nick Roberts wrote:
 
> 2006-12-14 ÂNick Roberts Â<nickrob@snap.net.nz>
> 
> * gdb.mi/mi-var-cp.exp: New test for references to pointers.
> 
> * gdb.mi/mi-var-cp.cc: Remove unnecessary string quotes.

This comment likely applies to .exp file, not .cc.  Besides, 
it would be better not to mix style changes with essential changes,
to simplify review.

Ah, and I've posted a patch to move most of .exp into .cc file,
so I guess we've mid-air collision.

> (reference_to_pointer): New procedure for above test.

Am I missing something, or this change is not included in
your mail? Ah, I think it's the CVS problem, whereas added
files are not included in diff.


> + set end_of_proc [gdb_get_line_number "return 99;"]
> + send_gdb "-exec-next 4\n"
> + gdb_expect {
> + Â Â -re
> "\\^running\r\n${mi_gdb_prompt}\\*stopped,reason=\"end-stepping-range\",thread-id=\"\[01\]\",frame=\{addr=\"$hex\",func=\"reference_to_pointer\",args=\\\[\\\],file=\".*${srcfile}\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$end_of_proc\"\}\r\n$mi_gdb_prompt$"
> { + ÂÂÂÂÂÂpass "4xnext to return 99" + Â Â }
> + Â Â timeout { fail "4xnext in reference_to_pointer (timeout)" }
> + }

FWIW, once my "Simplified MI tests" patch is checked in, this block
can be just removed.

> +
> + mi_create_varobj RPTR rptr_s "create varobj for rptr_s"
> +
> + mi_list_varobj_children RPTR {{RPTR.public public 2}} \
> + Â Â "list public child of RPTR"
> +
> + mi_list_varobj_children ÂRPTR.public \
> + Â Â {{RPTR.public.i i 0 int}
> + Â Â Â{RPTR.public.j j 0 int}} "list children of reference to pointer"
> +
> + mi_check_varobj_value RPTR.public.i 67 "check i member"
> + mi_check_varobj_value RPTR.public.j 89 "check j member"

Looks good. I've poked at this manually and it seems to work like
it should.

Now I guess you need to post a patch including the C++ file changes,
now that it's in CVS, and we need to find somebody who can actually
approve the patch.

Thanks,
Volodya