This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] testsuite fixes for stubs
- From: Pedro Alves <pedro_alves at portugalmail dot pt>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 13 Dec 2006 20:11:21 +0000
- Subject: [PATCH] testsuite fixes for stubs
Hi all,
The attached patch removes 109 FAILS while testing the yet unsubmitted
arm-wince gdbserver port.
These FAILS should be happening on testsuite runs ran against most
gdbserver/stub.
The problem is that the tests are issuing 'break $linenumber', assuming
the current file is
the correct one, but since the breaks are being issued before the
run/continue,
the current file is (usually) the file where the entry point is.
The fix is pretty obvious. Specify explicitly the file where to break.
Cheers,
Pedro Alves
---
2006-12-13 Pedro Alves <pedro_alves@portugalmail.pt>
* gdb.base/charset.exp: Add explicit filename to break.
* gdb.base/dbx.exp: Add explicit filename to breaks.
Index: charset.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/charset.exp,v
retrieving revision 1.6
diff -u -p -r1.6 charset.exp
--- charset.exp 13 May 2005 17:36:43 -0000 1.6
+++ charset.exp 13 Dec 2006 19:53:36 -0000
@@ -388,7 +388,7 @@ foreach host_charset [all_charset_names]
# some strings in various target character sets. We need to run the
# test program to the point at which the strings have been
# initialized.
-gdb_test "break [gdb_get_line_number "all strings initialized"]" \
+gdb_test "break charset.c:[gdb_get_line_number "all strings initialized"]" \
".*Breakpoint.* at .*" \
"set breakpoint after all strings have been initialized"
gdb_run_cmd
Index: dbx.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dbx.exp,v
retrieving revision 1.5
diff -u -p -r1.5 dbx.exp
--- dbx.exp 10 Aug 2006 05:27:20 -0000 1.5
+++ dbx.exp 13 Dec 2006 19:53:37 -0000
@@ -266,8 +266,8 @@ proc gdb_file_cmd {arg} {
proc test_breakpoints { } {
gdb_test "stop in main" "Breakpoint.*at.*: file.*average\.c, line 38\."
gdb_test "status" "Num.*Type.*Disp.*Enb.*Address.*What\r\n1\[ \r\]+breakpoint\[ \r\]+keep y.*in main at.*average\.c:38.*"
- gdb_test "stop at 43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
- gdb_test "stop in 43" "Usage: stop in <function . address>"
+ gdb_test "stop at average\.c:43" "Breakpoint.*at.*: file.*average\.c, line 43.*"
+ gdb_test "stop in average\.c:43" "Usage: stop in <function . address>"
gdb_test "stop at main" "Usage: stop at <line>"
}