This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] A few Cygwin testsuite fixes.


On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote:
>Hi all,
>
>This patch fixes a few fails on i686-pc-cygwin.
>- It adds a few missing $EXEEXT.
>- Adds a new $DLLEXT variable for the dynamic library tests and uses it.
>
>Please review and commit.

I don't have the right to approve or commit this but I have to say that
while the logic looks ok, I don't think the name of the variable you're
using should be "DLLEXT".  A "DLL" is generally a windows thing.  Maybe
it should be SOEXT instead.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]