This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
- From: Chet Ramey <chet dot ramey at case dot edu>
- To: "H. J. Lu" <hjl at lucon dot org>, GDB <gdb-patches at sources dot redhat dot com>, jkratoch at redhat dot com
- Cc: bug-readline at gnu dot org, chet dot ramey at case dot edu
- Date: Sat, 02 Dec 2006 14:17:15 -0500
- Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
- References: <20061121213205.GA13310@lucon.org> <20061128164658.GB20882@nevyn.them.org> <20061128165844.GA13667@lucon.org> <20061202184344.GA2197@lucon.org> <20061202185548.GA11402@nevyn.them.org>
- Reply-to: chet dot ramey at case dot edu
Daniel Jacobowitz wrote:
> On Sat, Dec 02, 2006 at 10:43:44AM -0800, H. J. Lu wrote:
>> 2006-12-02 H.J. Lu <hongjiu.lu@intel.com>
>> Jan Kratochvil <jkratoch@redhat.com>
>>
>> PR tui/2173
>> * readline.c (readline): Unset and reset RL_STATE_CALLBACK if
>> needed.
>
> This looks reasonable to me; I was wrong about longjmp since Readline's
> signal handlers will be installed. If Chet accepts this or a similar
> fix for the next release of readline, then you can apply it to our
> copy.
In general, readline's signal handlers will restore any application-
installed handlers before resending the signal to itself. This means
that any signal can potentially cause an application's handler to be
called, and longjmp to be called from that.
Now we would be relying on the application's signal handler to restore
the appropriate readline state.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
Live Strong. No day but today.
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/