This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove REALTIME_HI/LO macros from target headers
On Tue, Nov 28, 2006 at 07:50:59PM +0100, Ulrich Weigand wrote:
> Right. The nm-linux.h define should be redundant too. However, it
> is actually the correct version; the one at the top of signals.c
> is off by one. (SIGRTMAX is the number of last real-time signal,
> REALTIME_HI is supposed to be one beyond the number of the last
> real-time signal.)
>
> So we should fix the default definition in signals.c, and then
> remove the redundant define in nm-linux.h. In fact, this would
> allow to remove the #include <signal.h> from nm-linux.h as well,
> but that *might* cause breakage if any of the native Linux targets
> happens to rely on that implicit inclusion of <signal.h>.
> That's unfortunately a bit hard to test for ...
I'm not too worried about it. Let's assume it won't be a problem, and
if it is, it's easy to fix.
> > Patch looks OK modulo that question.
>
> Would it be OK to commit the current patch as-is, and do the removal
> from nm-linux.h as a follow-on patch?
Yes, that's fine; the current patch is OK.
--
Daniel Jacobowitz
CodeSourcery