This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa/doc] Re: RFC: A change to the way we initialize new gdbarches


> Date: Thu, 9 Nov 2006 14:50:12 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Index: src/gdb/doc/gdbint.texinfo
> ===================================================================
> --- src.orig/gdb/doc/gdbint.texinfo	2006-11-09 14:14:55.000000000 -0500
> +++ src/gdb/doc/gdbint.texinfo	2006-11-09 14:33:05.000000000 -0500

Thanks.  This patch is fine with me, except for the following minor
comment:

> +The initialization function has this type:
> +
> +@smallexample
> +static struct gdbarch *
> +@var{arch}_gdbarch_init (struct gdbarch_info info,
> +                         struct gdbarch_list *arches)
> +@end smallexample
> +
> +The @var{info} argument contains parameters used to select the correct
> +architecture, and @var{arches} is a list of architectures which

I think both `info' and `arches' should have a @var markup in the
@smallexample as well, to make them consistent with the following text
that describes them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]