This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add 'static' keyword


"Pierre Muller" <muller@ics.u-strasbg.fr> writes:
>    The problem is that I am not really a confirmed C code writer,
> I basically started C programming to add pascal language
> support in GDB.
>    The same kind of error could be repeated in several
> other locations, I did not even think that it was
> a good practice to repeat 'static' in the implementation.
>
>   Don't hesitate to correct others.

Thanks!  It's no big problem.  I did look at the other functions, and
it seemed fine.

I was looking into correcting the warnings produced by the stock
Fedora Core 5 compiler --- I understand the warnings don't occur any
more, but copying around obstack structures is gross --- but when I
realized I didn't have a pascal compiler installed to test the change
anyway, I lost enthusiasm for the change.

So all GDB got in the end was one 'static'.  :(


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]