This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix inconsistent usage of FRAME_OBSTACK_ZALLOC macro
- From: Daniel Jacobowitz <drow at false dot org>
- To: fnf at diveadx dot com
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Mon, 24 Jul 2006 17:10:08 -0400
- Subject: Re: [PATCH] Fix inconsistent usage of FRAME_OBSTACK_ZALLOC macro
- References: <200607241705.37217.fnf@ninemoons.com>
On Mon, Jul 24, 2006 at 05:05:37PM -0400, Fred Fish wrote:
> Of the 50+ places that reference frame_obstack_zalloc(), about 50 of
> them use the FRAME_OBSTACK_ZALLOC macro. The rest call the function
> directly.
>
> This patch makes them all consistently use the macro.
I gather you didn't test Alpha. This patch is wrong.
> - info->saved_regs = frame_obstack_zalloc (SIZEOF_FRAME_SAVED_REGS);
> + info->saved_regs = FRAME_OBSTACK_ZALLOC (SIZEOF_FRAME_SAVED_REGS);
That will probably allocate sizeof (int).
--
Daniel Jacobowitz
CodeSourcery