This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] print newline after copyright message


Daniel Jacobowitz wrote:
On Wed, Jul 19, 2006 at 01:33:34PM -0700, Bob Wilson wrote:
2006-07-19 Bob Wilson <bob.wilson@acm.org>

* main.c (captured_main): Print a newline after calling
print_gdb_version instead of waiting until after the symbol file
has been read. Adjust {error,quit,warning}_pre_print values.



Thanks, I agree with your logic. This patch is OK. Please don't use {A,B} notation in changelogs, though - spell it out.

I don't work on GDB much, so I'm not on the write-after-approval list in the MAINTAINERS file. If my write access for binutils applies to the gdb directory (I don't know how that works), I would be happy to apply the patch. Is that OK? Otherwise, would you apply it for me? Here is the revised changelog:


2006-07-24 Bob Wilson <bob.wilson@acm.org>

	* main.c (captured_main): Print a newline after calling
	print_gdb_version instead of waiting until after the symbol file
	has been read.  Adjust error_pre_print, quit_pre_print, and
	warning_pre_print values.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]