This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] command trace / source verbose mode
> Date: Thu, 20 Jul 2006 17:46:21 +0100
> From: Andrew STUBBS <andrew.stubbs@st.com>
> Cc: gdb-patches@sources.redhat.com
>
> Here is an updated version of my patch. I think I have addressed all
> your points.
Thanks.
> - if (file == NULL)
> + if (file == NULL || strlen (file) == 0)
^^^^^^^^^^^^^^^^^^
Nitpicking: isn't it better to use *file == 0 instead?
> error (_("source command requires pathname of file to source."));
Another nit: the GNU project does not like to use ``pathname''; please
use ``file name'' (yes, two words) instead.
> +Optional -v switch (before the filename) causes each command in\n\
> +FILE to be echo as it is executed.\n\
^^^^^^^^^^
You meant "to be echoed", right?
> Note that the file \"%s\" is read automatically in this way\n\
> when gdb is started."), gdbinit);
I think "gdb" should be up-cased.
> +If you need to debug user-defined commands or sourced files you may find it
> +useful to enable command tracing.
This paragraph could benefit from two small changes:
. enclose "command tracing" in the above sentence in @dfn{}, to make
it stand out--this is a new term you are introducing here
. add "@cindex command tracing" before the paragraph
Otherwise, the patch is okay with me. Thanks.