This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix powerpc 64bit backtrace code
- From: Daniel Jacobowitz <drow at false dot org>
- To: Anton Blanchard <anton at samba dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 8 Jun 2006 14:41:34 -0400
- Subject: Re: [PATCH] Fix powerpc 64bit backtrace code
- References: <20060602023824.GC1736@krispykreme>
On Fri, Jun 02, 2006 at 12:38:24PM +1000, Anton Blanchard wrote:
> Knowing this I looked through the backtrace code and it looks like the
> fallback is incorrect. If we fail to determine the stack layout
> accurately we should make a guess based on the ABI. It turns out
> tdep->lr_frame_offset was created for this purpose, but isnt used
> anywhere.
Yep. It was used, but that code is long gone; I think I added the
fallback you're fixing, but I didn't know about lr_frame_offset.
The patch looks right.
Do you have write access to src? If so, you can check this in and add
your name to write-after-approval in MAINTAINERS. Or I can check it in
for you; just let me know which.
--
Daniel Jacobowitz
CodeSourcery