This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Don't use deprecated regcache functions


David S. Miller wrote:
From: Michael Snyder <msnyder@redhat.com>
Date: Wed, 12 Apr 2006 19:41:42 -0700


I get confused just thinking about all these variants.
If you have an argument for why one is more correct in
this context, I'm certainly open to it.  I can't really
convince myself that the current behavior is correct,
since deprecated_read_register_gen calls regcache_cooked_read,
which may call regcache_raw_read, which may call
target_fetch_registers *before* capturing the current value.
Which it seems like would defeat the purpose of the whole
exercise...


Any of these arguments for or against apply to the Solaris thread code
which does use regcache_raw_read() in this same exact situation.


Oh, I see -- you did mention that you were emulating that code, but I didn't read thoroughly -- I thought you were only referring to the fetch_registers call.

Well, I'm gonna plead ignorance, then.  I don't know enough
to say whether the change is correct or not.

Daniel? Mark?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]