This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] solib-som.c fix for hpux


On Fri, 24 Mar 2006 15:23:15 -0500
Daniel Jacobowitz <drow@false.org> wrote:

> On Fri, Mar 24, 2006 at 01:25:37PM +0800, Randolph Chung wrote:
> > Dan J's change to solib handling
> > (http://sources.redhat.com/ml/gdb-patches/2006-01/msg00198.html) exposed
> > a probably unfounded assumption in the SOM solib code that assumes that
> > the solib_create_inferior_hook will always be called before current_sos.
> > As a result, gdb cvs on HPUX 32-bit would always error out when trying
> > to run any executable with the message "Debugging dynamic executables
> > loaded via the hpux8 dld.sl is not supported.". The most straightforward
> > fix is to remove the error and handle the case where there is not yet a
> > link map; that is what I have in the patch below. OTOH this does remove
> > the error message if anybody does try to run gdb on hpux8 (!!!)
> 
> Grr!  I tried to catch all of these.  Some assume that add is called
> first... others assume that create is called first...
> 
> > 2006-03-24  Randolph Chung  <tausq@debian.org>
> > 
> > 	* solib-som.c (link_map_start): Don't error out if there is
> > 	not yet a link map.
> 
> It seems OK to me, but I don't want to approve SOM changes; maybe get
> Kevin's opinion, since this is a shared library topic?

It looks okay to me too.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]