This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove type prefix for -var-evaluate-expression/functions


On Fri, Mar 17, 2006 at 01:19:54PM +0300, Vladimir Prus wrote:
> On Friday 17 March 2006 13:02, Nick Roberts wrote:
> > > > > the following patch removes 'type prefix' from output of
> > > > > -var-evaluate-expression applied to objects of function type (not
> > > > > pointers to functions, but functions).
> > > > >
> > > > > It causes no regression in the testsuite for me.
> > > >
> > > > But I guess a new test would help prevent a regression (in the code) in
> > > > the future.
> > >
> > > Yes, can you suggest which file should I add this new testcase too?
> >
> > Well I guess mi-var-cmd.exp.  Please remember that I'm not the maintainer
> > but just an interested party.  See what Daniel says.  He might want
> > something for mi2-var-cmd.exp too.
> 
> Ok, I'll wait for his comment.

mi-var-cmd.exp sounds good to me.  I don't think we need it in
mi2-var-cmd.exp.  I have the same question I asked a moment ago about
Nick's patch - is there any chance that someone relies on this
information?

Here I think the chance is pretty slim; for pointers it's a more
serious concern, but for functions this is a pretty rare case.
So not versioning this change makes sense to me.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]