This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Clean up "show remote"


> Date: Sun, 22 Jan 2006 15:17:59 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> Does anyone have an opinion on this patch?  It's, um, a bit inelegant;
> but it removes the hardcoded list of subcommands in show_remote_cmd, which
> happens to be missing two.  I always try "show remote" when I want to
> remember the spelling of "set remote hardware-breakpoint-limit", but
> it didn't include that.

This patch is fine with me, in general.

> Also shorten the messages a bit by removing redundancy; either the user
> typed config->title, or it was prefixed to the output already.

I'm not quite sure I get this.  With the current code, "show remote"
outputs lines like this:

 Support for remote protocol `Z0' (software-breakpoint) packet is auto-detected,
 currently unknown.

With your change, the part in parentheses will not be displayed, so
how would the user know that Z0 is a packet that sets software
breakpoints?

> An alternative if the code in show_remote_cmd is too ugly would be to delete
> "show remote Z-packet".  I think we have to leave "set remote Z-packet" -
> it's five years obsoleted but never marked as deprecated and I know people
> are continuing to use it - but the show command is completely redundant.

I think what you did is fine, but perhaps explain a bit more in
comments about why Z-packet is redundant, and that maybe it should be
removed later on.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]