This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [SH] PATCH: Define the register groups
- From: Daniel Jacobowitz <drow at false dot org>
- To: Andrew STUBBS <andrew dot stubbs at st dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 20 Jan 2006 18:35:20 -0500
- Subject: Re: [SH] PATCH: Define the register groups
- References: <436105B8.7020605@st.com> <436F6CF7.1070003@st.com>
On Mon, Nov 07, 2005 at 03:04:23PM +0000, Andrew STUBBS wrote:
> * sh-tdep.c: Include reggroups.h.
> (sh_register_reggroup_p): New function.
> (sh_gdbarch_init): Add call to set_gdbarch_register_reggroup_p.
> * Makefile.in (sh-tdep.o): Add dependency on reggroups.h.
Just a couple of questions for you, only one of which involves changing
anything:
- Are the fv registers for floating point vectors? Since you
put them in both info float and info vector. I'm guessing that
they are. Makes sense.
- Can we reuse default_register_reggroup_p for most of this, and
just handle the register numbers that it's likely to get
wrong? e.g. we probably do need to handle FPUL here - but
calling the default will handle dr0 just fine.
- You've put a bunch of registers in system_reggroup (e.g. pc, pr)
that other folks don't; but no one besides the TUI uses that
anyway, so it doesn't really matter. I wouldn't have included
those two. I don't remember what the other ones you listed do,
so I've got no idea about them :-)
--
Daniel Jacobowitz
CodeSourcery