This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Assignment of aggregates in Ada


> Please be sure to include in _() all strings that are messages
> displayed to the user.  This is in preparation for GDB's i18n, at some
> future date.

My mistake.  I will submit an obvious patch that takes care of all
these cases after committing these two.

> > +		error ("Illegal attempt to select from type: \"%s\".", name0.ptr);
> 
> Using ``illegal'' in a context that doesn't deal with laws is a no-no
> in GNU projects.  ``Invalid'' is the usual replacement.

OK.

> I think an example or two here would help clarify what you are saying.
> 
> Also a @cindex entry might be a good idea, for example:
> 
>   @cindex array and record aggregates (Ada)

OK.

> Is the description above the only user-visible effect of these massive
> changes?  If not, I'd like to document the rest as well.

Yes, it is the only INTENTIONAL change at any rate (aside, of course,
from changes that convert errors into correct behavior).  

> > Index: gdb/doc/gdb.texinfo
> 
> Please include suitable entries for gdb/doc/ChangeLog.

OK.  Sorry; I had that change, but didn't send the changelog entry.

Paul Hilfinger


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]