Re: [RFC]: Patch to support Fortran derived type - Revised

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Sat, 10 Dec 2005 15:24:29 +0800 (CST)
> From: Wu Zhou <woodzltc@cn.ibm.com>
> cc: gdb-patches@sources.redhat.com, Thomas.Koenig@online.de
> 
> Here is the revised patch, testcase and documents.

Thanks.  My comments about the documentation patch are below.

> 2005-12-10  Wu Zhou  <woodzltc@cn.ibm.com>
> 
> 	* gdb.texinfo (Fortran): Document the "%" operator for member
> 	access.
> 	(Fortran): Document the type-print and value-print operation of
> 	Fortran 90 derived types.

These two entries reference the same node "Fortran", so there's no
need to mention the node twice.  Just write the two sentences one
after the other; you don't even need a newline between them.

> + @item %
> + ortran 90 and afterwards use this to access the members of derived
    ^^^^^^
A typo.

Also, I'd prefer "and later" instead of "and afterwards".

> + @cindex Structure type-print

Index entries by convention should begin with a lower-case letter.

> + Fortran 90 and afterwards support derived type (a.k.a structure).  For
               ^^^^^^^^^^^^^^
"and later"

> + a variable of derived type, ptype command will output all its members,
                                ^^^^^
Please give each command the @code markup: @code{ptype}.  Actually,
"the @code{ptype} command" is more correct English, I think.

> + @noindent
> + ptype commands give this output:
    ^^^^^^^^^^^^^^
"the @code{ptype} commands"

> + @end smallexample
> + 
> + @noindent
> + 

This @noindent looks unnecessary to me.  Why did you add it?

> + @cindex Structure value-print

Again, please begin all index entries with a lower-case letter.

> + @item print @var{derived-type}
> + For a variable of derived type, print command will output the value of
                                    ^^^^^^^^^^^^^
"the @code{print} command"

> + For example, for variable q of type foo defined above:

`q' and `foo' are Fortran symbols, so both of them should have the
@code markup: "for a variable @code{q} of type @code{foo} defined above".

> + @noindent
> + print command will output this:
    ^^^^^^^^^^^^^
"the @code{print} command"

> + $1 = @{ 3.125, @{ 1, 2.375@}, (97 'a', 98 'b', 99 'c', 100 'd', 101 'e', 102 'f', 103 'g')@}

This is too long for a single line (TeX will not break lines inside
@smallexample).  Please break it into 2 lines, and please add text
saying that it's a single long line, broken only for clarity.