This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] GDB patches for hw watchpoints - revised


Wu Zhou wrote:

> 4. Mark said that we can't add anything more to nm.h.  The revised patch 
> changed that and add most of them to target vector.  But we had to find a 
> way to set TARGET_REGION_OK_FOR_HW_WATCHPOINT for ppc64 arch. I am now 
> setting that in nm-ppc64-linux.h.  Is that okay?  Maybe we need to set 
> TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT instead? 

You should be setting the target vector's to_region_size_ok_for_hw_watchpoint
function instead.  See s390-nat.c where I now implement full watchpoint
support without any nm.h macro defined ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]