This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[COMMIT] Add vscr register to 'list' of PowerPC vector registers.


I went with the least intrusive.

Here is what I comitted: (From 'cvs diff -Nau' this time. Hope this is better. 8-)


2005-10-14  Paul Gilliam  <pgilliam@us.ibm.com>

        * rs6000-tdep.c (rs6000_register_reggroup_p): Add vscr to test for
        vector registers.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.245
diff -a -u -r1.245 rs6000-tdep.c
--- rs6000-tdep.c       6 Oct 2005 00:22:57 -0000       1.245
+++ rs6000-tdep.c       14 Oct 2005 20:11:02 -0000
@@ -1888,6 +1888,7 @@
              || (tdep->ppc_ev0_regnum >= 0
                  && regnum >= tdep->ppc_ev0_regnum
                  && regnum < tdep->ppc_ev0_regnum + 32)
+             || regnum == tdep->ppc_vrsave_regnum - 1 /* vscr */
              || regnum == tdep->ppc_vrsave_regnum
              || regnum == tdep->ppc_acc_regnum
              || regnum == tdep->ppc_spefscr_regnum);








On Friday 14 October 2005 12:15, Daniel Jacobowitz wrote:
> On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote:
> > The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register.
> > Consiquetly, it was not printed along with the other vector registers using the 'info vector' command.
> > 
> > Two patches follow:  the first fixes the problem with the least amount of fuss.
> > 
> > The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that.
> > This version was prompted by this comment in rs6000-tdep.c:
> >        /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum,
> >           we can treat this more like the other cases.  */
> > 
> > Which should i commit?
> 
> You should also try posting patches using a readable diff format :-)
> (unified, please, or at least context).
> 
> I have no preferences on the actual patch.
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]