This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mi_gdb_test MESSAGE parameter


On Mon, Aug 01, 2005 at 02:31:45PM -0400, Bob Rossi wrote:
> Hi,
> 
> Here is a pre-patch to my previous testsuite patch. I think it makes a
> lot of sense to make the MESSAGE parameter to mi_gdb_test necessary.
> There was only 1 testcase not using the MESSAGE parameter, and it was
> using it 1/2 the time.

I agree.  This is basically OK.  Please fix two little things for me
and check it in.

> 2005-08-1   Bob Rossi  <bob@brasko.net>

2005-08-01

> -mi_gdb_test "400-break-insert foo" "400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}"
> +mi_gdb_test "400-break-insert foo" \
> +"400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}" \
> +"insert breakpoint foo"

Please indend continued lines.  I'm not sure what the standard
indentation is in the testsuite but two spaces, four spaces, or a tab
is probably a good bet.  I see all three in use.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]