This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: tests for MI commands

Daniel Jacobowitz writes:
 > You've broken many of the other tests using the source files you've
 > modified.  Please, run the entire GDB testsuite before committing
 > patches - as testsuites go it really doesn't take very long.

 ...
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout)
 > +ERROR: Couldn't send -var-update * to GDB.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed
 > 
 > Please fix them - I think the easiest thing to do is to revert the
 > changes to the affected source files and switch those two modified
 > tests to using new source files.

I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to
mi2-stack.exp and mi2-var-child.exp.  Creating new files mi-var-cmd.c,
mi-basics.c etc seems more complicated.  Is this an acceptable short term
solution?

Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]