This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] -stack-select-frame


On Thu, Jun 16, 2005 at 03:37:08PM +1200, Nick Roberts wrote:
> 
> Last year I submitted a dreadful patch for -stack-select-frame
> (thread subject: How does GDB/MI give the current frame).
> 
> Here, hopefully, is a much more sensible one.  The idea is the same: that
> -stack-select-frame tells the frontend what the current or selected frame
> is.
> 
> The current documentation for -stack-select-frame is slightly wrong because
> the argument FRAMENUM is optional.  I've corrected this and explained what
> the patch does.

- You're changing the behavior of a command; do people use this
command?  Are you confident that they will handle the new output
gracefully?

- Please, let's not add new MI features without matching testcases.

> ! ^done,frame=@{level="2",addr="0x000107a4",func="foo",
> !   file="recursive2.c",fullname="/home/foo/bar/devo/myproject/recursive2.c",line=line="14"@},

The double line= is a typo, right?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]