Re: [PATCH] -data-list-changed-registers (Take 2)

[Nick Roberts <nickrob at snap dot net dot nz>]

 > > From mi_cmd_data_list_register_values, I removed:
 > > 
 > > if (!target_has_registers)
 > >   {
 > >     mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers.");
 > >     return MI_CMD_ERROR;
 > >   }
 > > 
 > > Why do you think it should stay?
 > 
 > Cuz it was late and I wasn't paying a great deal of attention to your
 > patch, once I figured out the mi_out_rewind problem.  In the interest
 > of uniformity, let's remove it.  Could you (test and) commit the
 > obvious patch?

Committed.

I get many failures on the testsuite, I'll try to move to a newer PC/kernel.
mi-regs.exp seems OK though.

I would like to commit my changes to -var-update (2005-05-02) sometime.

I have also removed a large number of annotations from my working copy.
Andrew started this process, it would be nice if he can be involved but
maybe thats not possible. There are a lot of changes to the following files:

gdb/ada-valprint.c
gdb/annotate.c
gdb/annotate.h
gdb/blockframe.c
gdb/breakpoint.c
gdb/cp-valprint.c
gdb/event-top.c
gdb/frame.c
gdb/infrun.c
gdb/interps.c
gdb/jv-valprint.c
gdb/p-valprint.c
gdb/printcmd.c
gdb/stack.c
gdb/utils.c
gdb/valprint.c

Is anyone interested?  It would be good to do this now as a release doesn't
seem to be imminent.

Nick


2005-06-14  Nick Roberts  <nickrob@snap.net.nz>

	* mi/mi-main.c (mi_cmd_data_list_register_values): Remove test for
	registers now that mi_execute_command rewinds after an error.


*** /home/nick/src/gdb/mi/mi-main.c.~1.79~	2005-06-14 10:37:18.000000000 +1200
--- /home/nick/src/gdb/mi/mi-main.c	2005-06-14 09:18:08.000000000 +1200
***************
*** 433,444 ****
  
    format = (int) argv[0][0];
  
-   if (!target_has_registers)
-     {
-       mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers.");
-       return MI_CMD_ERROR;
-     }
- 
    list_cleanup = make_cleanup_ui_out_list_begin_end (uiout, "register-values");
  
    if (argc == 1)		/* No args, beside the format: do all the regs */
--- 433,438 ----