This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit/obvious] sh64-tdep.c: Avoid gcc warnings


Commited as obvious.


Corinna

	* MAINTAINERS: Remove hint that sh64 doesn't build.
	* sh64-tdep.c (sh64_push_dummy_call): Cast buf in call to write_memory.
	(sh64_do_fp_register): make raw_buffer unsigned.
	(sh64_do_register): Ditto.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/src/src/gdb/MAINTAINERS,v
retrieving revision 1.314
diff -u -p -r1.314 MAINTAINERS
--- MAINTAINERS	1 May 2005 23:07:33 -0000	1.314
+++ MAINTAINERS	2 May 2005 15:17:04 -0000
@@ -111,8 +111,7 @@ the native maintainer when resolving ABI
 	s390		--target=s390-linux-gnu ,-Werror
 
 	sh		--target=sh-elf ,-Werror
-			--target=sh64-elf broken
-			(sim/ dies)
+			--target=sh64-elf ,-Werror
 
 	sparc		--target=sparc-elf broken
 			(bfd/elfxx-sparc:512 bfd_elf64_swap_reloca_out undef)
Index: sh64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh64-tdep.c,v
retrieving revision 1.37
diff -u -p -r1.37 sh64-tdep.c
--- sh64-tdep.c	15 Apr 2005 08:01:14 -0000	1.37
+++ sh64-tdep.c	2 May 2005 15:17:05 -0000
@@ -1120,7 +1120,8 @@ sh64_push_dummy_call (struct gdbarch *gd
 	      if (int_argreg > ARGLAST_REGNUM)
 		{			
 		  /* must go on the stack */
-		  write_memory (sp + stack_offset, val, argreg_size);
+		  write_memory (sp + stack_offset, (const bfd_byte *) val,
+		  		argreg_size);
 		  stack_offset += 8;/*argreg_size;*/
 		}
 	      /* NOTE WELL!!!!!  This is not an "else if" clause!!!
@@ -1962,13 +1963,13 @@ static void
 sh64_do_fp_register (struct gdbarch *gdbarch, struct ui_file *file,
 		     struct frame_info *frame, int regnum)
 {				/* do values for FP (float) regs */
-  char *raw_buffer;
+  unsigned char *raw_buffer;
   double flt;	/* double extracted from raw hex data */
   int inv;
   int j;
 
   /* Allocate space for the float.  */
-  raw_buffer = (char *) alloca (register_size (gdbarch, FP0_REGNUM));
+  raw_buffer = (unsigned char *) alloca (register_size (gdbarch, FP0_REGNUM));
 
   /* Get the data in raw format.  */
   if (!frame_register_read (frame, regnum, raw_buffer))
@@ -1993,7 +1994,7 @@ sh64_do_fp_register (struct gdbarch *gdb
     {
       int idx = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? j
 	: register_size (gdbarch, regnum) - 1 - j;
-      fprintf_filtered (file, "%02x", (unsigned char) raw_buffer[idx]);
+      fprintf_filtered (file, "%02x", raw_buffer[idx]);
     }
   fprintf_filtered (file, ")");
   fprintf_filtered (file, "\n");
@@ -2074,7 +2075,7 @@ static void
 sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file,
 		  struct frame_info *frame, int regnum)
 {
-  char raw_buffer[MAX_REGISTER_SIZE];
+  unsigned char raw_buffer[MAX_REGISTER_SIZE];
 
   fputs_filtered (REGISTER_NAME (regnum), file);
   print_spaces_filtered (15 - strlen (REGISTER_NAME (regnum)), file);

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]