Re: [RFC] fullname attribute for GDB/MI stack frames

[Daniel Jacobowitz <drow at false dot org>]

On Fri, Apr 01, 2005 at 02:13:33PM -0500, Dennis Brueni wrote:
> > Again, for the fullname regex, I would recommend using the 
> > same regex used in mi-file.exp. This would be like 
> > fullname="/.*basics.c" This forces the regex to ensure that 
> > the path is absolute, which the check you have does not.

Will GDB always output absolute paths that start with "/"?  What about
non-Cygwin Windows for example?  DJGPP?

In any case, if you want to verify that fullname starts with a
full path, it can be an independent test.  It doesn't need to live in
every other MI stack test.

> > 
> > Bob Rossi
> >
> 
> As promised, here is an updated patch set with the regex
> changes you suggested, plus checking for a little more directory
> information with respect to the fullname path, to the extent
> that we can be sure the test case still passes in all environments.

I don't think adding fullname= to the -i=mi2 output is a good idea; MI2
is supposed to be stable.  Bob, what do you think?  Anyone else?



A couple administrative things about submitting GDB patches:

- Please include ChangeLog entries as text, not as diff.  They'll never
apply correctly when someone else wants to test or commit the patch.

- Please use full sentences.  This:

> + 	* stack.c (print_frame): In MI mode,
> + 	output fullname attribute with stack frame

becomes:

	* stack.c (print_frame): In MI mode, output the fullname
	attribute with the stack frame.

- Follow the GNU coding standards (you can find a copy on gnu.org) in
any new code.  For instance, spaces before parentheses in function
calls; and braces on new lines rather than at the end of existing
lines.

You don't need to redo the patch; I'll take care of it once my first
questions are resolved.


-- 
Daniel Jacobowitz
CodeSourcery, LLC