This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Readline on MinGW

Chet Ramey wrote: 
Eli, just to be clear, you said you "support" the patches I posted (with
this exception).  I'm interpreting that as "I hope they go into upstream
readline", rather than as "it's OK to check these patches into the GDB
repository."  If you actually meant the latter, let me know. :-)



I only looked at the changes briefly, but they looked fine.  I would
not, in any case, replace `kill' with `raise' without an autoconf test.

OK. I'll add an autoconf test for "kill" and then use "raise" only if "kill" is unavailable. I'll repost with that change soon.

Unless there's something fatally wrong with the patch, I don't have a
problem incorporating it into the readline distribution.

Great, thank you!

Eli, et. al., does that mean that it's OK to check the patch into GDB now? What procedure do we use from here?

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]